gptel-gemini: Support thoughtSignature in tool calls #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surenkov
force-pushed
the
master
branch
2 times, most recently
from
d8732c3 to
385fc46
Compare
surenkov
force-pushed
the
master
branch
3 times, most recently
from
b18c8cb to
2b930c2
Compare
surenkov
force-pushed
the
master
branch
6 times, most recently
from
e8d2063 to
1488db6
Compare
surenkov
added a commit
to surenkov/gptel-test
that referenced
this pull request
Dec 8, 2025
Also fix `model` parts, transforming them into vectors of plists, in accordance to Gemini API. This should play in conjunction with karthink/gptel#1154
Contributor
Author
|
Strictly speaking, I haven't got any idea better than to put the signature as an @karthink can you please take a look at these changes? Is there a better place of storing these signatures? |
Owner
|
Strictly speaking, I haven't got any idea better than to put the signature as an `:id` of the tool call. At least Gemini does not provide real call ids, and placing the signatures there doesn't break any existing behavior, allowing to carry them across multiple conversation turns.
@karthink can you please take a look at these changes? Is there a better place of storing these signatures?
Thanks! I'll take a look at the changes soon. I hope it's clear that no changes are needed to send thoughtSignatures _between_ invocations of gptel-send -- after a tool call, I think they are being sent automatically with the tool result.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Gemini backend to preserve
thoughtSignaturefields, which is mandatory for Gemini 3 Pro and recommended for Gemini 2.5.Gemini reasoning models return an encrypted
thoughtSignaturealongside text or function calls to maintain reasoning context in their stateless API. Per Gemini API specifications:Previously,
gptel-geminidiscarded this signature. This change ensures the signature is retained and sent back in the conversation history for subsequent turns, preventing API errors with reasoning models.Changes:
thoughtSignatureis extracted and attached to the tool-use plist:idproperty if afunctionCallis present and the signature is supplied in the response.thoughtSignatureis stored as a'gptel-gemini-thought-signaturetext property on the response content in the buffer.thoughtSignatureis then included in the message structure sent back to the Gemini API.Closes #1146